gitgabrio commented on PR #2203: URL: https://github.com/apache/incubator-kie-tools/pull/2203#issuecomment-2008727738
HI @tiagobento thanks for PR. IMO, the root problem is the usage of a completely custom-made marshaller (IIUC the code). Such approach never works in real use case, simple reason is that xsd are big, they keep changing, and keep the code in sync with changes requires a lot of time and is error prone. Even if this modificaiont fix the current problem, it is just one, and probably there are multiple ones that are never been discovered only because not tested. The very fact that we found multiple bugs in two hours, testing only five extremely simple models, and none of them is 1.5 specific, should be a clear demonstration of that. I may see this as temporary solution, but I think a different approach is needed here. Anyway, this is not my area, and I have not your knowledge, so the final choice is yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
