domhanak commented on code in PR #585:
URL:
https://github.com/apache/incubator-kie-kogito-docs/pull/585#discussion_r1532042668
##########
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc:
##########
@@ -0,0 +1,106 @@
+= Workflow embedded execution in Java
+
+This guide uses a standard Java virtual machine and a small set of Maven
dependencies to execute a link:{spec_doc_url}[CNCF Serverless Workflow]
definition. Therefore, it is assumed you are fluent both in Java and Maven.
+The workflow definition to be executed can be read from a `.json` or `.yaml`
file or programmatically defined using the {product_name} fluent API.
+
+[[embedded-file-quick-start]]
+== Hello world (using existing definition file)
+
+The first step is to set up an empty Maven project with the following
dependency:
+
+[source,xml]
+----
+<dependency>
+ <groupId>org.kie.kogito</groupId>
+ <artifactId>kogito-serverless-workflow-executor-core</artifactId>
+ <version>RELEASE</version>
Review Comment:
suggestion 1: we could reference maven repository of this dependency for
better UX.
suggestion 2: use some variable from `antora.yaml` which is unified across
the docs, `sonataflow_kie_apache_version=999.0.0-SNAPSHOT` ( for releases, we
fix it to 10.0.0.Final ). Unfication can be done later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
