fjtirado commented on code in PR #3403:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3403#discussion_r1533612333
##########
api/kogito-api/src/main/java/org/kie/kogito/process/ProcessInstances.java:
##########
@@ -33,9 +33,18 @@ default Optional<ProcessInstance<T>>
findByBusinessKey(String id) {
return stream().filter(pi -> id.equals(pi.businessKey())).findAny();
}
+ default void migrate(String targetProcessId, String targetProcessVersion,
String... processIds) throws UnsupportedOperationException {
Review Comment:
But usually, what I have seen in this case is to use @throws in the JavaDoc,
not explicitly declare the runtime exception at interface level.
Anyway, taking benefit of Java multiple inheritance of interface, it wont be
better to move this method to a new interface, MigrateCapability, and implement
it on the persiscent addons that really support migration rather than declaring
throws UnsupportedOperationException in the interface declaration and
overriding the method only in the ones that support it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
