yurloc opened a new pull request, #5804: URL: https://github.com/apache/incubator-kie-drools/pull/5804
Fixes #5719. Fixes several tests scattered around the `drools-model-codegen` module. I've enabled the affected disabled tests but I chose not to create new tests for these reasons: 1. Line numbers are a cross-cutting concern and I'd rather not pollute the existing parser tests in `MiscDRLParserTest` by adding line number assertions there. 2. I don't see much added value in creating new dedicated tests since we have a decent coverage in the codegen module. 3. #5798 will ensure every `BaseDescr` receives these properties so testing that will be much simpler. ### Before PR in `drools-model-codegen` ``` [ERROR] Tests run: 2433, Failures: 275, Errors: 0, Skipped: 9 ``` ### After PR in `drools-model-codegen` ``` [ERROR] Tests run: 2434, Failures: 252, Errors: 0, Skipped: 9 ``` <details> <summary> How to replicate CI configuration locally? </summary> Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it. </details> <details> <summary> How to retest this PR or trigger a specific build: </summary> - for <b>pull request and downstream checks</b> - Push a new commit to the PR. An empty commit would be enough. - for a <b>full downstream build</b> - for <b>github actions</b> job: add the label `run_fdb` - for <b>Jenkins PR check only</b> - If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
