gitgabrio commented on code in PR #2207:
URL:
https://github.com/apache/incubator-kie-tools/pull/2207#discussion_r1537724355
##########
packages/dmn-marshaller/tests/idempotency.test.ts:
##########
@@ -20,30 +20,61 @@
import * as fs from "fs";
import * as path from "path";
import { getMarshaller } from "@kie-tools/dmn-marshaller";
+import { DmnMarshaller, DmnMarshallerOpts, DmnMarshallerVersions } from
"../src";
const files = [
- "../tests-data--manual/other/attachment.dmn",
- "../tests-data--manual/other/empty13.dmn",
- "../tests-data--manual/other/sample12.dmn",
- "../tests-data--manual/other/list.dmn",
- "../tests-data--manual/other/list2.dmn",
- "../tests-data--manual/other/external.dmn",
- "../tests-data--manual/other/weird.dmn",
- "../tests-data--manual/dmn-1_4--examples/Chapter 11 Example 1
Originations/Chapter 11 Example.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_5/AllowedValuesChecksInsideCollection.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_5/DateToDateTimeFunction.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_5/ForLoopDatesEvaluate.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_5/Imported_Model_Unamed.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_5/Importing_EmptyNamed_Model.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_5/ListReplaceEvaluate.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_5/TypeConstraintsChecks.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_x/OneOfEachType.dmn",
+
"../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_x/allTypes.dmn",
+];
+
+const testing_models_paths = [
+ "../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_5",
+ "../node_modules/@kie-tools/dmn-testing-models/dist/valid_models/DMNv1_x",
];
describe("idempotency", () => {
for (const file of files) {
- test(path.basename(file), () => {
- const xml_original = fs.readFileSync(path.join(__dirname, file),
"utf-8");
-
- const { parser, builder } = getMarshaller(xml_original, { upgradeTo:
"latest" });
- const json = parser.parse();
-
- const xml_firstPass = builder.build(json);
- const xml_secondPass = builder.build(getMarshaller(xml_firstPass, {
upgradeTo: "latest" }).parser.parse());
+ testFile(path.join(__dirname, file));
+ }
+});
- expect(xml_firstPass).toStrictEqual(xml_secondPass);
- });
+describe("idempotency_all", () => {
+ for (const models_paths of testing_models_paths) {
+ const parent_path = path.join(__dirname, models_paths);
+ testDirectory(parent_path);
}
Review Comment:
@jomarko I see the point, but IMO:
1. these class has two testing methods, one of which uses explicitily
defined files
2. one of the goal is to allow "transparent" inclusion of new models, i.e.
whenever we add a model to the original jar, it will immediately goes under
test, enhancing bug-discovery time; having to synchronize the expected number
(or also name) of files would impair noticeably that, making PR much more
cumbersome to create
3. if we move the test elsewhere, the method will throw a directory not
found (or similar) error
4. the only way to move files to different directory would be changing the
pom.xml itself, in which case I'm expecting people to be aware of consequences
5. the other possibility would be to change the structure of the jar itself,
but there seems no reason to do that and, eventually, the modification should
be reflected to the pom.xml, to keep the same destination folder
Does this make sense ? WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
