tkobayas commented on code in PR #5806:
URL:
https://github.com/apache/incubator-kie-drools/pull/5806#discussion_r1540761143
##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRL6Expressions.g4:
##########
@@ -230,6 +230,7 @@ drlIdentifier returns [Token token]
| PERMITS
| RECORD
| VAR
+ | THIS
Review Comment:
Now, I add `THIS` to `drlIdentifier` (in both `DRLParser.g4` and
`DRL6Expressions.g4`) because the original `DRL6Expressions.g` treated `this`
as `ID` in `primary` rule (remember that `| this_key ...` line was commented
out). `this` is involved with DRL specific syntax like inline cast
(`this#Person`) and null dereference (`this.address!.city`). So I think it's
better to include it in `drlIdentifier` so that we can keep parser rules simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
