tiagobento commented on PR #2211: URL: https://github.com/apache/incubator-kie-tools/pull/2211#issuecomment-2025794614
@ljmotta Looking at the `jsonModel.ts` fixture you introduced, I have a couple of thoughts: 1. The wait mechanism is flawed, we can do better with a new optional prop called `onModelDebounceStateChanged` only render the JSON once debounce is completed. 2. The `drgElements.ts` file has too much logic. IMHO we shouldn't be abstracting direct access to the JSON model itself. IMHO it's alright to use hard-coded indexes to find stuff in the array, as we expect that the JSON model will be stable. 3. The strategy of using the DOM to make the JSON available to the tests is a clever hack, well done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
