tkobayas commented on code in PR #5819:
URL:
https://github.com/apache/incubator-kie-drools/pull/5819#discussion_r1549165807
##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLParser.g4:
##########
@@ -198,6 +198,7 @@ drlIdentifier
| RECORD
| VAR
| THIS
+ | PACKAGE
Review Comment:
> 1. I would stick with 100% backward compatibility; without that, something
that was working previously, simply stop to work, and it is not clear who/how
would fix the issues that will popup, nor how much time this could take
Okay, I'm not opinionated on this. We can go with Option A and leave Option
C as a future enhancement possibility.
> 2. I wonder (again, just asking) if there is not a programmatic way to
automatically add all the java keywords from JavaLexer to `drlIdentifier :
drlKeywords` - and then keep going with option A (IIUC)
There is no programmatic way because those Java keywords are individually
declared in `JavaLexer.g4`. I think explicitly listing them in `drlIdentifier`
is readable enough.
Thanks,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
