paulovmr commented on code in PR #1900:
URL:
https://github.com/apache/incubator-kie-kogito-examples/pull/1900#discussion_r1550319648
##########
kogito-springboot-examples/pom.xml:
##########
@@ -127,7 +125,6 @@
<module>process-springboot-example</module>
<module>process-timer-springboot</module>
<module>process-usertasks-custom-lifecycle-springboot</module>
- <module>process-usertasks-springboot-with-console</module>
<module>process-usertasks-springboot</module>
<module>process-usertasks-with-security-oidc-springboot-with-console</module>
Review Comment:
I believe this line should be removed too.
##########
kogito-quarkus-examples/pom.xml:
##########
@@ -95,11 +95,9 @@
<module>process-service-calls-quarkus</module>
<module>process-timer-quarkus</module>
<module>process-usertasks-custom-lifecycle-quarkus</module>
- <module>process-usertasks-quarkus-with-console</module>
Review Comment:
Please consider removing this module from the other profile as well.
##########
kogito-quarkus-examples/pom.xml:
##########
@@ -95,11 +95,9 @@
<module>process-service-calls-quarkus</module>
<module>process-timer-quarkus</module>
<module>process-usertasks-custom-lifecycle-quarkus</module>
- <module>process-usertasks-quarkus-with-console</module>
<module>process-usertasks-quarkus</module>
<module>process-usertasks-timer-quarkus-with-console</module>
<module>process-usertasks-timer-data-index-persistence-addon-quarkus</module>
-
<module>process-usertasks-with-security-oidc-quarkus-with-console</module>
Review Comment:
Please consider removing this module from the other profile as well.
##########
serverless-workflow-examples/pom.xml:
##########
@@ -47,7 +47,6 @@
<module>serverless-workflow-callback-quarkus</module>
<module>serverless-workflow-camel-routes</module>
<module>serverless-workflow-compensation-quarkus</module>
- <module>serverless-workflow-consuming-events-over-http-quarkus</module>
Review Comment:
I believe we can keep this module and just remove the Dev UI references from
it. The README has some steps using curl as well, which are still valid. The
section `Running the example from Quarkus Dev UI` could be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
