gitgabrio commented on PR #5827: URL: https://github.com/apache/incubator-kie-drools/pull/5827#issuecomment-2036798120
Thanks @tkobayas , good stuff! I've made a slight modification on top of you B) proposal that somehow mix B) and C) 1. a "Factory" class (with builder pattern) 2. remove instantiation concern from `DescrHelper` Reason for that: 1. use common and well-known design pattern 2. clearly define and separate concerns - the factory is responsible of instantiation, the Helper is responsible of manipulation - the two should be somehow independent 3. extensibility: if/ever, there will be need to add a "needed" parameter at instantiation time, the builder pattern allows easy extension (the init method would requires overrides or parameters explosion) My proposal is [here](https://github.com/gitgabrio/drools/tree/incubator-kie-drools-5798-descr-props-DescrHelper) @tkobayas @mariofusco @yurloc wdyt ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
