gitgabrio commented on code in PR #2207:
URL:
https://github.com/apache/incubator-kie-tools/pull/2207#discussion_r1555273489
##########
packages/dmn-marshaller/tests/jbang/dmnValidation.java:
##########
@@ -27,16 +26,16 @@ public static void main(String... args) throws Exception {
public static int validate(String... args) throws Exception {
if (args.length > 2 || args.length <= 0) {
- throw new IllegalArgumentException("Validation requires 1 or 2
xmls");
+ throw new IllegalArgumentException("Validation requires 1 or 2 DMN
file paths");
Review Comment:
@yesamer
Please keep in mind that there could be more then two models in the "import"
scenario; e.g.
1. model A import both model B and model C
2. model A import model B that, in turn, import model C
3. ecc
Please remove the `args.length > 2 ` constraint, and adapt the exception
message accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
