fjtirado commented on code in PR #3464:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3464#discussion_r1556344485
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/deployment/ServerlessWorkflowDevServicesProcessor.java:
##########
@@ -36,4 +43,14 @@ public void logger(BuildProducer<AdditionalBeanBuildItem>
additionalBean, Launch
}
}
+ @BuildStep(onlyIf = { GlobalDevServicesConfig.Enabled.class,
IsDevelopment.class })
+ CardPageBuildItem createDevUILink(List<SystemPropertyBuildItem>
systemPropertyBuildItems) {
+ String data_index_url = getProperty(systemPropertyBuildItems,
"kogito.data-index.url");
Review Comment:
What happens if there is not "kogito.data-index.url" in the properties?
I believe a NullPointerException will be launch in line 50
Maybe getProperty should return Optional and only add the button if the
property is there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
