porcelli commented on code in PR #2228:
URL:
https://github.com/apache/incubator-kie-tools/pull/2228#discussion_r1556547955
##########
packages/dashbuilder/appformer/pom.xml:
##########
@@ -439,7 +440,7 @@
</configuration>
</plugin>
- <!--Fix translations from Zanata -->
+ <!-- Fix translations from Zanata -->
Review Comment:
Unnecessary change?
##########
packages/dmn-marshaller/src/schemas/dmn-1_5/Dmn15Spec.ts:
##########
@@ -101,4 +101,4 @@ export const allDmnImportNamespaces = new Set([
dmn15ns.get("")!,
]);
-export const KIE_DMN_UNKNOWN_NAMESPACE = "https://kie.org/dmn/unknown";;
+export const KIE_DMN_UNKNOWN_NAMESPACE = "https://kie.apache.org/dmn/unknown";;
Review Comment:
same question: how this affects users from previous version using new editor
##########
packages/kn-plugin-workflow/pkg/command/quarkus/build.go:
##########
@@ -21,13 +21,14 @@ package quarkus
import (
"fmt"
+ "regexp"
Review Comment:
Is this change needed?
##########
packages/dashbuilder/appformer/pom.xml:
##########
@@ -345,7 +346,7 @@
<version>1.3</version>
</plugin>
- <!--This plugin's configuration is used to store Eclipse m2e settings
+ <!-- This plugin's configuration is used to store Eclipse m2e settings
Review Comment:
unnecessary change :)
##########
packages/dashbuilder/appformer/pom.xml:
##########
@@ -82,11 +82,12 @@
<netty-transport-native-epoll-classifier>linux-x86_64</netty-transport-native-epoll-classifier>
<netty-transport-native-kqueue-classifier>osx-x86_64</netty-transport-native-kqueue-classifier>
- <version.bundle.plugin
Review Comment:
Probably this can be reverted
##########
packages/dashbuilder/appformer/pom.xml:
##########
@@ -82,11 +82,12 @@
<netty-transport-native-epoll-classifier>linux-x86_64</netty-transport-native-epoll-classifier>
<netty-transport-native-kqueue-classifier>osx-x86_64</netty-transport-native-kqueue-classifier>
- <version.bundle.plugin
- >3.3.0</version.bundle.plugin><!-- 3.2.0 sometimes
- fails with NPE during parallel build -->
+ <!-- 3.2.0 sometimes fails with NPE during parallel build -->
+ <version.bundle.plugin>3.3.0</version.bundle.plugin>
+
<!-- Make OSGi happy -->
<osgi.snapshot.qualifier>${maven.build.timestamp}</osgi.snapshot.qualifier>
+
<jboss.releases.repo.url
>https://repository.jboss.org/nexus/service/local/staging/deploy/maven2/</jboss.releases.repo.url>
Review Comment:
isn't Apache staging better repo to use?
##########
packages/dmn-editor/stories/misc/empty/Empty.stories.tsx:
##########
@@ -29,7 +29,7 @@ export const generateEmptyDmn15 = () => `<?xml version="1.0"
encoding="UTF-8"?>
<definitions
xmlns="${dmn15ns.get("")}"
expressionLanguage="${DMN15_SPEC.expressionLanguage.default}"
- namespace="https://kie.org/dmn/${generateUuid()}"
+ namespace="https://kie.apache.org/dmn/${generateUuid()}"
Review Comment:
will this break users coming from precisou version and using new editor?
how this affects runtime engine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
