tomasdavidorg commented on code in PR #1902: URL: https://github.com/apache/incubator-kie-kogito-examples/pull/1902#discussion_r1559362605
########## serverless-operator-examples/sonataflow-apisix-oidc/README.md: ########## @@ -0,0 +1,3 @@ +# SonataFlow Authentication and Authorization with Keycloak and APISIX + +This is an example directory to support the guide outlined here: [https://sonataflow.org/serverlessworkflow/latest/cloud/custom-ingress-authz.html](https://sonataflow.org/serverlessworkflow/latest/cloud/index.html). Please read it in order to understand how to use this example fully. Review Comment: Is it intentional to point to `index.html` or there should be `custom-ingress-authz.html`? ########## serverless-operator-examples/sonataflow-apisix-oidc/README.md: ########## @@ -0,0 +1,3 @@ +# SonataFlow Authentication and Authorization with Keycloak and APISIX + +This is an example directory to support the guide outlined here: [https://sonataflow.org/serverlessworkflow/latest/cloud/custom-ingress-authz.html](https://sonataflow.org/serverlessworkflow/latest/cloud/index.html). Please read it in order to understand how to use this example fully. Review Comment: ```suggestion This is an example directory to support the guide outlined here: [https://sonataflow.org/serverlessworkflow/latest/cloud/custom-ingress-authz.html](https://sonataflow.org/serverlessworkflow/latest/cloud/index.html). Please read it in order to fully understand how to use this example. ``` ########## serverless-operator-examples/sonataflow-apisix-oidc/workflow-app/greeting.sw.yaml: ########## @@ -0,0 +1,55 @@ +# Copyright 2024 Apache Software Foundation (ASF) Review Comment: Please fix formatting and indentation. ########## serverless-operator-examples/sonataflow-apisix-oidc/workflow-app/greeting.sw.yaml: ########## @@ -0,0 +1,55 @@ +# Copyright 2024 Apache Software Foundation (ASF) +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +id: 'workflow_unique_identifier' +version: '0.1' +specVersion: '0.8' +name: 'Workflow name' +description: 'Workflow description' +functions: + - name: greetFunction + type: custom + operation: sysout +start: ChooseOnLanguage +states: + - name: ChooseOnLanguage + type: switch + dataConditions: + - condition: "${ .language == \"English\" }" + transition: GreetInEnglish + - condition: "${ .language == \"Spanish\" }" + transition: GreetInSpanish + defaultCondition: + transition: GreetInEnglish + - name: GreetInEnglish + type: inject + data: + greeting: "Hello from JSON Workflow, " + transition: GreetPerson + - name: GreetInSpanish + type: inject + data: + greeting: "Saludos desde JSON Workflow, " Review Comment: ```suggestion greeting: "Saludos desde YAML Workflow, " ``` ########## serverless-operator-examples/sonataflow-apisix-oidc/manifests/bases/02-keycloak.yaml: ########## @@ -0,0 +1,87 @@ +# Copyright 2024 Apache Software Foundation (ASF) Review Comment: Please fix formatting and indentation. ########## serverless-operator-examples/sonataflow-apisix-oidc/manifests/bases/kustomization.yaml: ########## @@ -0,0 +1,37 @@ +# Copyright 2024 Apache Software Foundation (ASF) Review Comment: Please fix formatting and indentation. ########## serverless-operator-examples/sonataflow-apisix-oidc/workflow-app/greeting.sw.yaml: ########## @@ -0,0 +1,55 @@ +# Copyright 2024 Apache Software Foundation (ASF) +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +id: 'workflow_unique_identifier' +version: '0.1' +specVersion: '0.8' +name: 'Workflow name' +description: 'Workflow description' +functions: + - name: greetFunction + type: custom + operation: sysout +start: ChooseOnLanguage +states: + - name: ChooseOnLanguage + type: switch + dataConditions: + - condition: "${ .language == \"English\" }" + transition: GreetInEnglish + - condition: "${ .language == \"Spanish\" }" + transition: GreetInSpanish + defaultCondition: + transition: GreetInEnglish + - name: GreetInEnglish + type: inject + data: + greeting: "Hello from JSON Workflow, " Review Comment: ```suggestion greeting: "Hello from YAML Workflow, " ``` ########## serverless-operator-examples/sonataflow-apisix-oidc/workflow-app/01-sonataflow-greeting.yaml: ########## @@ -0,0 +1,58 @@ +# Copyright 2024 Apache Software Foundation (ASF) +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: sonataflow.org/v1alpha08 +kind: SonataFlow +metadata: + name: greeting + annotations: + sonataflow.org/description: Greeting example on k8s! + sonataflow.org/version: 0.0.1 +spec: + flow: + start: ChooseOnLanguage + functions: + - name: greetFunction + type: custom + operation: sysout + states: + - name: ChooseOnLanguage + type: switch + dataConditions: + - condition: "${ .language == \"English\" }" + transition: GreetInEnglish + - condition: "${ .language == \"Spanish\" }" + transition: GreetInSpanish + defaultCondition: GreetInEnglish + - name: GreetInEnglish + type: inject + data: + greeting: "Hello from JSON Workflow, " + transition: GreetPerson + - name: GreetInSpanish + type: inject + data: + greeting: "Saludos desde JSON Workflow, " Review Comment: ```suggestion greeting: "Saludos desde YAML Workflow, " ``` ########## serverless-operator-examples/sonataflow-apisix-oidc/workflow-app/01-sonataflow-greeting.yaml: ########## @@ -0,0 +1,58 @@ +# Copyright 2024 Apache Software Foundation (ASF) +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: sonataflow.org/v1alpha08 +kind: SonataFlow +metadata: + name: greeting + annotations: + sonataflow.org/description: Greeting example on k8s! + sonataflow.org/version: 0.0.1 +spec: + flow: + start: ChooseOnLanguage + functions: + - name: greetFunction + type: custom + operation: sysout + states: + - name: ChooseOnLanguage + type: switch + dataConditions: + - condition: "${ .language == \"English\" }" + transition: GreetInEnglish + - condition: "${ .language == \"Spanish\" }" + transition: GreetInSpanish + defaultCondition: GreetInEnglish + - name: GreetInEnglish + type: inject + data: + greeting: "Hello from JSON Workflow, " Review Comment: ```suggestion greeting: "Hello from YAML Workflow, " ``` ########## serverless-operator-examples/sonataflow-apisix-oidc/workflow-app/02-sonataflow-route.yaml: ########## @@ -0,0 +1,40 @@ +# Copyright 2024 Apache Software Foundation (ASF) Review Comment: Please fix formatting and indentation. ########## serverless-operator-examples/sonataflow-apisix-oidc/manifests/bases/01-postgres.yaml: ########## @@ -0,0 +1,86 @@ +# Copyright 2024 Apache Software Foundation (ASF) Review Comment: Please fix formatting and indentation. ########## serverless-operator-examples/sonataflow-apisix-oidc/workflow-app/01-sonataflow-greeting.yaml: ########## @@ -0,0 +1,58 @@ +# Copyright 2024 Apache Software Foundation (ASF) Review Comment: Please fix formatting and indentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
