tiagobento commented on PR #2209: URL: https://github.com/apache/incubator-kie-tools/pull/2209#issuecomment-2052236336
Ok, so I think what happens is: 1. The typo was only on Windows scripts. 2. The build succeedded, but running the binaries on Windows would be broken, as QuarkusVersion would be `nil`. 3. Since we don't run E2E tests on Windows, we this PR didn't catch it! Other than enabling the E2E tests on Windows, I'm not sure how we could've caught this. I found it by chance in logs.. Anyway, all good for now, despite the gap in correctness we have... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
