tkobayas commented on code in PR #5845:
URL:
https://github.com/apache/incubator-kie-drools/pull/5845#discussion_r1565443452
##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRL6Expressions.g4:
##########
@@ -30,12 +30,7 @@ options {
@members {
private ParserHelper helper;
- public DRL6Expressions(TokenStream input,
- ParserHelper helper ) {
- this( input );
- this.helper = helper;
- }
-
+ public void setHelper( ParserHelper helper ) { this.helper =
helper; }
Review Comment:
Removing the `DRL6Expressions` constructor is okay. We can use another
constructor `new DRL6Expressions(input)` and `setHelper`. `DRLParser` can also
inject `ParserHelper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
