ljmotta commented on PR #2131:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2131#issuecomment-2056684041

   @jomarko Thanks a lot for your review! I'll answer the raised observations 
inline:
   
   1 - We have opted to use only constraints from custom data types, instead of 
letting create constraints on the Decision Table header. 
   2 - As mentioned on 1, to create a constraint it’s necessary to create a 
custom data type, and not a `Structure`.
   3 - It’s not related to this PR. I've confirmed on the `dailydev` env. Can 
you create a new issue so we can track this?
   4 - This is a serious problem. I will take a look into it.
   5 - I guess it would be good to incorporate this.
   6 -
     - It shouldn’t be possible to change the node data type! Can you create an 
issue for this bug?
     - Regarding the boxed expression, we have disabled the option to open it.
   
   7 -
     - We’re not tracking then, but I’ll add it to the 945 epic.
     - I’ll improve the comment. The disabled shortcuts are from Storybook and 
not from the Boxed Expression. It was causing a conflict with the Monaco editor.
     - The `description` is a `tag` of the DMN XSD. The `@_` is a property of a 
tag.
   
   8 - This is a bug on the `dailydev` environment too. Can you create an issue 
to track this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to