JaredDavis22 commented on code in PR #5837:
URL:
https://github.com/apache/incubator-kie-drools/pull/5837#discussion_r1565730491
##########
drools-model/drools-canonical-model/src/main/java/org/drools/model/operators/MatchesOperator.java:
##########
@@ -20,13 +20,67 @@
import org.drools.model.functions.Operator;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+
public enum MatchesOperator implements Operator.SingleValue<String, String> {
INSTANCE;
+ // not final due to unit tests
+ private int MAX_SIZE_CACHE = getMaxSizeCache();
Review Comment:
I thought we have a singleton only usage since it is an enum. Does that make
all class variables in a sense static? Want me to change it? I did not
benchmark it either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
