domhanak commented on code in PR #443:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/443#discussion_r1566912118


##########
operator.yaml:
##########
@@ -969,6 +969,78 @@ spec:
                     - secretRef
                     type: object
                 type: object
+              properties:
+                description: "Properties defines the property set for a given 
actor
+                  in the current context. For example, the workflow managed 
properties.
+                  One can define here a set of properties for SonataFlow 
deployments
+                  that will be reused across every workflow deployment. \n 
These properties
+                  MAY NOT be propagated to a SonataFlowClusterPlatform since 
PropertyVarSource
+                  can only refer local context sources."
+                properties:
+                  flow:
+                    description: Properties that will be added to the 
SonataFlow managed
+                      configMaps in the current context.
+                    items:
+                      description: PropertyVar is the entry for a property set 
derived
+                        from the Kubernetes API EnvVar. Note that the name 
doesn't
+                        have to match C_IDENTIFIER.
+                      properties:
+                        name:
+                          description: The property name
+                          type: string
+                        value:
+                          description: Defaults to "".
+                          type: string
+                        valueFrom:
+                          description: Source for the property's value. Cannot 
be
+                            used if value is not empty.
+                          properties:
+                            configMapKeyRef:
+                              description: Selects a key of a ConfigMap.
+                              properties:
+                                key:
+                                  description: The key to select.
+                                  type: string
+                                name:
+                                  description: 'Name of the referent. More 
info: 
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                                    TODO: Add other useful fields. apiVersion, 
kind,
+                                    uid?'
+                                  type: string
+                                optional:
+                                  description: Specify whether the ConfigMap 
or its
+                                    key must be defined
+                                  type: boolean
+                              required:
+                              - key
+                              type: object
+                              x-kubernetes-map-type: atomic
+                            secretKeyRef:
+                              description: Selects a key of a secret in the 
flow's
+                                namespace
+                              properties:
+                                key:
+                                  description: The key of the secret to select 
from.  Must
+                                    be a valid secret key.
+                                  type: string
+                                name:
+                                  description: 'Name of the referent. More 
info: 
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                                    TODO: Add other useful fields. apiVersion, 
kind,

Review Comment:
   todo, noting to sure it is not left over



##########
operator.yaml:
##########
@@ -969,6 +969,78 @@ spec:
                     - secretRef
                     type: object
                 type: object
+              properties:
+                description: "Properties defines the property set for a given 
actor
+                  in the current context. For example, the workflow managed 
properties.
+                  One can define here a set of properties for SonataFlow 
deployments
+                  that will be reused across every workflow deployment. \n 
These properties
+                  MAY NOT be propagated to a SonataFlowClusterPlatform since 
PropertyVarSource
+                  can only refer local context sources."
+                properties:
+                  flow:
+                    description: Properties that will be added to the 
SonataFlow managed
+                      configMaps in the current context.
+                    items:
+                      description: PropertyVar is the entry for a property set 
derived
+                        from the Kubernetes API EnvVar. Note that the name 
doesn't
+                        have to match C_IDENTIFIER.
+                      properties:
+                        name:
+                          description: The property name
+                          type: string
+                        value:
+                          description: Defaults to "".
+                          type: string
+                        valueFrom:
+                          description: Source for the property's value. Cannot 
be
+                            used if value is not empty.
+                          properties:
+                            configMapKeyRef:
+                              description: Selects a key of a ConfigMap.
+                              properties:
+                                key:
+                                  description: The key to select.
+                                  type: string
+                                name:
+                                  description: 'Name of the referent. More 
info: 
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                                    TODO: Add other useful fields. apiVersion, 
kind,
+                                    uid?'
+                                  type: string
+                                optional:
+                                  description: Specify whether the ConfigMap 
or its
+                                    key must be defined
+                                  type: boolean
+                              required:
+                              - key
+                              type: object
+                              x-kubernetes-map-type: atomic
+                            secretKeyRef:
+                              description: Selects a key of a secret in the 
flow's
+                                namespace
+                              properties:
+                                key:
+                                  description: The key of the secret to select 
from.  Must
+                                    be a valid secret key.
+                                  type: string
+                                name:
+                                  description: 'Name of the referent. More 
info: 
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                                    TODO: Add other useful fields. apiVersion, 
kind,

Review Comment:
   todo, noting to ensure it is not left over



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to