gitgabrio commented on code in PR #3468: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3468#discussion_r1568662625
########## kogito-serverless-workflow/kogito-serverless-workflow-dmn-parser/src/test/resources/Traffic Violation.dmn: ########## @@ -0,0 +1,230 @@ +<?xml version='1.0' encoding='UTF-8'?> +<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/"; xmlns="https://github.com/kiegroup/drools/kie-dmn/_A4BCA8B8-CF08-433F-93B2-A2598F19ECFF"; xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; xmlns:kie="http://www.drools.org/kie/dmn/1.2"; xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/"; xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; id="_1C792953-80DB-4B32-99EB-25FBE32BAF9E" name="Traffic Violation" expressionLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/"; typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/"; namespace="https://github.com/kiegroup/drools/kie-dmn/_A4BCA8B8-CF08-433F-93B2-A2598F19ECFF";> Review Comment: HI @fjtirado We created a"testing" module containing all the dmn files used for testing purposes [here](https://github.com/apache/incubator-kie-drools/tree/main/kie-dmn/kie-dmn-test-resources) We did that to be sure that the files used around are perfectly compatible (and validated) by our engine. And also to stop a bit this uncontrolled proliferation of dmns 😄 (Side note: Traffic Violation.dmn is probably the most used models all over) ########## kogito-bom/pom.xml: ########## @@ -1941,6 +1941,28 @@ <version>${project.version}</version> <classifier>sources</classifier> </dependency> + <dependency> + <groupId>org.kie.kogito</groupId> + <artifactId>kogito-serverless-workflow-dmn-parser</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.kie.kogito</groupId> + <artifactId>kogito-serverless-workflow-dmn-parser</artifactId> + <version>${project.version}</version> + <classifier>sources</classifier> + </dependency> + <dependency> + <groupId>org.kie.kogito</groupId> + <artifactId>kogito-serverless-workflow-dmn</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> Review Comment: @fjtirado OUt of curiosity: why the dependency on `sources` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
