porcelli commented on code in PR #3478: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3478#discussion_r1579769274
########## jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/main/resources/class-templates/StaticProcessTemplate.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.jbpm.process.codegen; + +import java.util.HashMap; +import java.util.Map; + +import org.drools.core.util.KieFunctions; + +import org.jbpm.process.core.context.variable.Variable; +import org.jbpm.process.core.context.variable.VariableScope; +import org.jbpm.ruleflow.core.RuleFlowProcessFactory; +import org.jbpm.workflow.core.WorkflowProcess; +import org.kie.api.definition.process.Process; +import org.kie.api.runtime.process.WorkflowProcessInstance; +import org.kie.kogito.Application; +import org.kie.kogito.Model; +import org.kie.kogito.correlation.CompositeCorrelation; +import org.kie.kogito.process.ProcessConfig; +import org.kie.kogito.process.ProcessInstance; +import org.kie.kogito.process.bpmn2.BpmnProcess; +import org.kie.kogito.process.bpmn2.BpmnProcessInstance; +import org.kie.kogito.process.bpmn2.BpmnProcesses; +import org.kie.kogito.process.bpmn2.BpmnVariables; +import org.kie.kogito.process.impl.AbstractProcess; + +public class XXX extends AbstractProcess<Model> { Review Comment: XXXX? ########## jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/canonical/LambdaSubProcessNodeVisitor.java: ########## @@ -143,15 +149,22 @@ private BlockStmt bind(ModelMetaData subProcessModel) { } private BlockStmt createInstance(SubProcessNode subProcessNode, ProcessMetaData metadata) { - + // return app.get(Processes.class).<Model>processById(subprocessId).createInstance(model); Review Comment: why comment here? ########## kogito-build/kogito-dependencies-bom/pom.xml: ########## @@ -122,15 +122,17 @@ <version.org.slf4j>2.0.6</version.org.slf4j> <version.maven>3.9.3</version.maven> + <version.maven.project>2.2.1</version.maven.project> <version.maven.plugin>3.7.1</version.maven.plugin> <version.maven.invoker>3.2.0</version.maven.invoker> - + <version.maven.plugin.testing.harness>4.0.0-alpha-2</version.maven.plugin.testing.harness> <version.plexus>2.1.0</version.plexus> <version.plexus.classworld>2.6.0</version.plexus.classworld> <!-- see: https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html#parallel-test-execution-and-single-thread-execution --> <version.com.github.stephenc.jcip>1.0-1</version.com.github.stephenc.jcip> <version.black.ninia>4.2.0</version.black.ninia> + <version.com.google.collections>1.0</version.com.google.collections> Review Comment: note: this might be impacted by Quarkus upgrade ########## jbpm/jbpm-tools/jbpm-tools-maven-plugin/src/test/resources/unit/project/src/main/bpmn/BPMN2-MinimalProcess.bak: ########## @@ -0,0 +1,29 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: is this file needed? ########## jbpm/jbpm-tests/src/test/bpmn/org/jbpm/bpmn2/flow/BPMN2-MultipleProcessInOneFile.bpmn2: ########## @@ -6,9 +6,9 @@ xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://www.omg.org/spec/BPMN/20100524/MODEL BPMN20.xsd" - xmlns:tns="http://www.example.org/EvaluationExample";> + xmlns:tns="http://www.jboss.org/drools";> Review Comment: eventually we need change this to apache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
