jomarko commented on code in PR #2288:
URL:
https://github.com/apache/incubator-kie-tools/pull/2288#discussion_r1589101720
##########
packages/dmn-editor/src/mutations/deleteNode.ts:
##########
@@ -131,7 +131,7 @@ export function deleteNode({
throw new Error(`DMN MUTATION: Unknown node nature '${nodeNature}'.`);
}
- if (!dmnObject) {
+ if (!dmnObject && nodeNature !== NodeNature.UNKNOWN) {
Review Comment:
In such scenario user spot the error reported in this ticket #2288 what is
from my point of view incorrect, because "Can't delete DMN object that doesn't
exist" message says we try to delete DMN object, but we delete only `DMNShape`
in case of Unknown node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
