wmedvede commented on code in PR #457:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/457#discussion_r1592137536


##########
bundle/manifests/sonataflow-operator-controllers-config_v1_configmap.yaml:
##########
@@ -29,6 +29,18 @@ data:
     sonataFlowDevModeImageTag: ""
     # The default name of the builder configMap in the operator's namespace
     builderConfigMapName: "sonataflow-operator-builder-config"
+    # Quarkus extensions required for workflows persistence. These extensions 
are used by the SonataFlow build system,
+    # in cases where the workflow being built has configured postgresql 
persistence.
+    postgreSQLPersistenceExtensions:
+      - groupId: io.quarkus
+        artifactId: quarkus-jdbc-postgresql
+        version: 3.2.10.Final

Review Comment:
   Hi  @domhanak , this information is already configured in one single place, 
here:  
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/457/files#diff-ddac596008b9e8c9968a61666b661f894cd11b277ac2515a59f042844413f15b,
 in the file **kogito-serverless-operator/config/manager/controllers_cfg.yaml** 
which is correct.
   
   Then, the reason why you can see this information in the files: 
**sonataflow-operator-controllers-config_v1_configmap.yaml** and 
**operator.yaml**, is because this files are automatically generated, and these 
files are necessary for the operator deployment, like the other manifests.
   
   But, the source of true for these generation is the file 
**controllers_cfg.yaml**.
   
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to