gitgabrio commented on code in PR #5907:
URL:
https://github.com/apache/incubator-kie-drools/pull/5907#discussion_r1593772882
##########
drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java:
##########
@@ -803,12 +803,19 @@ public AccumulateDescr
visitFromAccumulate(DRLParser.FromAccumulateContext ctx)
@Override
public AccumulateDescr.AccumulateFunctionCallDescr
visitAccumulateFunction(DRLParser.AccumulateFunctionContext ctx) {
String function = ctx.drlIdentifier().getText();
- String bind = ctx.label() == null ? null :
ctx.label().drlIdentifier().getText();
+ String bind = null;
+ boolean unify = false;
+ if (ctx.label() != null) {
Review Comment:
Hi @mariofusco
My point is about readibility: of course both versions are equals, but the
former (three lines) is easier to understand at first glance; the latter (two
lines) requires a little bit more effort (IMO), for someone that has to read it
for the first time.
On a broader POV, if the code is made by "easier to read" lines, it is less
tiring to read and work on (of course, I'm not talking of one specific line).
So, my comment, as usual, is target more to improve the readibility of the
code as whole, and that's achievable only by lot of very small improvements.
Anyway, I leave that to @tkobayas: hope this would make sense 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
