yurloc commented on issue #5915: URL: https://github.com/apache/incubator-kie-drools/issues/5915#issuecomment-2102817850
> Generally, the issue is that DRLVisitorImpl doesn't accept 0 size lhsPattern(). But each test may have its own issue (e.g. AnnotationsTest seems to have an annotation parsing issue) I confirm that. - `org.drools.mvel.integrationtests.AnnotationsTest#testAnnotationOnLHSAndMerging` (#5918) - and `org.drools.mvel.integrationtests.ExtendsTest#testExtendsBasic` (#5917) are not the best examples as they test correct DRL sources and fail due to parser issues. Once we fix the parser grammar, the visitor will be able to traverse the contexts smoothly. However, the other failing tests are good examples because they test invalid or incomplete DRL sources that do not have a completely parsed LHS. The visitor must be resilient to that and must not throw an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
