martinweiler commented on code in PR #3508:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3508#discussion_r1599762402


##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/VariableTagsTest.java:
##########
@@ -41,6 +47,19 @@
 
 public class VariableTagsTest extends JbpmBpmn2TestCase {
 
+    @Test
+    public void testVariableMultipleMetadata() throws Exception {
+        Application app = ProcessTestHelper.newApplication();
+        ApprovalWithRequiredVariableTagsProcess processDefinition = 
(ApprovalWithRequiredVariableTagsProcess) 
ApprovalWithRequiredVariableTagsProcess.newProcess(app);
+
+        RuleFlowProcess processEngine = (RuleFlowProcess) 
processDefinition.process();
+        Optional<Variable> var = 
processEngine.getVariableScope().getVariables().stream().filter(e -> 
"approver".equals(e.getName())).findAny();
+        assertThat(var).isPresent();
+        assertThat(var.get().getMetaData()).hasSize(3);
+        assertThat(var.get().getMetaData()).flatExtracting("ItemSubjectRef", 
"approver", "customTags");

Review Comment:
   Why is "ItemSubjectRef" and "approver" also considered metadata?
   
   Should there be a check for the metadata value as well, eg. 
   ```
   assertThat(var.get().getMetaData().get("customTags")).isEqualTo("required");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to