wmedvede commented on code in PR #1768: URL: https://github.com/apache/incubator-kie-kogito-images/pull/1768#discussion_r1606512904
########## README.md: ########## @@ -166,12 +166,12 @@ The Kogito Component Images can be considered as lightweight images that will co by providing extra capabilities, like managing the processes on a web UI or providing persistence layer to the Kogito applications. Today we have the following Kogito Component Images: -* [quay.io/kiegroup/kogito-data-index-ephemeral](https://quay.io/kiegroup/kogito-data-index-ephemeral) -* [quay.io/kiegroup/kogito-data-index-postgresql](https://quay.io/kiegroup/kogito-data-index-postgresql) -* [quay.io/kiegroup/kogito-jobs-service-ephemeral](https://quay.io/kiegroup/kogito-jobs-service-ephemeral) -* [quay.io/kiegroup/kogito-jobs-service-postgresql](https://quay.io/kiegroup/kogito-jobs-service-postgresql) -* [quay.io/kiegroup/kogito-jobs-service-allinone](https://quay.io/kiegroup/kogito-jobs-service-allinone) -* [quay.io/kiegroup/kogito-jit-runner](https://quay.io/kiegroup/kogito-jit-runner) +* [docker.io/apache/incubator-kie-kogito-data-index-ephemeral](https://docker.io/apache/incubator-kie-kogito-data-index-ephemeral) Review Comment: @ricardozanini General comment regarding this links for http navigation. I'm not sure if we shouldn't have a link like this instead. https://hub.docker.com/ bla bla bla. see for example: https://hub.docker.com/_/postgres Obviously not a blocker, we can adjust when we have the images publised and all the bits in place. ########## kogito-imagestream.yaml: ########## @@ -27,7 +27,7 @@ items: - kind: ImageStream apiVersion: v1 metadata: - name: kogito-swf-builder + name: sonataflow-builder Review Comment: shouldn't this be kie-sonataflow-builder? If not, just ignore this comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
