jstastny-cz commented on code in PR #5970:
URL:
https://github.com/apache/incubator-kie-drools/pull/5970#discussion_r1611775381
##########
.ci/jenkins/Jenkinsfile.deploy:
##########
@@ -121,14 +121,29 @@ pipeline {
} else {
installOrDeploy = 'install'
}
+ def mavenCommand = getMavenCommand()
+ .withOptions(env.DROOLS_BUILD_MVN_OPTS ? [
env.DROOLS_BUILD_MVN_OPTS ] : [])
+ .withOptions(env.BUILD_MVN_OPTS_CURRENT ? [
env.BUILD_MVN_OPTS_CURRENT ] : [])
+ .withProperty('maven.test.failure.ignore', true)
+ .skipTests(params.SKIP_TESTS)
+ .withSettingsXmlFile(MAVEN_SETTINGS_FILE)
Review Comment:
this needs to be in `configFileProvider` section for MAVEN_SETTINGS_FILE to
exist (it's tmp scoped to the defining configFileProvider block).
I'd say extend the configFileProvider block above the def mavenCommand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
