elguardian commented on code in PR #3558:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3558#discussion_r1634902149
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ActivityTest.java:
##########
@@ -1297,28 +1315,27 @@ public void testErrorBetweenProcessesProcess() throws
Exception {
}
@Test
- public void testProcessCustomDescriptionMetaData() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/flow/BPMN2-ProcessCustomDescriptionMetaData.bpmn2");
-
- Map<String, Object> params = new HashMap<>();
-
- KogitoProcessInstance processInstance =
kruntime.startProcess("ProcessCustomDescriptionMetaData", params);
- assertProcessInstanceCompleted(processInstance);
-
- String description = processInstance.getDescription();
+ public void testProcessCustomDescriptionMetaData() {
+ Application app = ProcessTestHelper.newApplication();
+ org.kie.kogito.process.Process<ProcessCustomDescriptionMetaDataModel>
process = ProcessCustomDescriptionMetaDataProcess.newProcess(app);
+ ProcessCustomDescriptionMetaDataModel model = process.createModel();
+ ProcessInstance<ProcessCustomDescriptionMetaDataModel> processInstance
= process.createInstance(model);
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
+ String description = processInstance.description();
assertThat(description).isNotNull().isEqualTo("my process with
description");
}
@Test
- public void testProcessVariableCustomDescriptionMetaData() throws
Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/flow/BPMN2-ProcessVariableCustomDescriptionMetaData.bpmn2");
-
- Map<String, Object> params = new HashMap<>();
- params.put("x", "variable name for process");
- KogitoProcessInstance processInstance =
kruntime.startProcess("ProcessVariableCustomDescriptionMetaData", params);
- assertProcessInstanceCompleted(processInstance);
-
- String description = processInstance.getDescription();
+ public void testProcessVariableCustomDescriptionMetaData() {
+ Application app = ProcessTestHelper.newApplication();
+
org.kie.kogito.process.Process<ProcessVariableCustomDescriptionMetaDataModel>
process = ProcessVariableCustomDescriptionMetaDataProcess.newProcess(app);
+ ProcessVariableCustomDescriptionMetaDataModel model =
process.createModel();
+ model.setX("variable name for process");
+ ProcessInstance<ProcessVariableCustomDescriptionMetaDataModel>
processInstance = process.createInstance(model);
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
+ String description = processInstance.description();
assertThat(description).isNotNull().isEqualTo("variable name for
process");
Review Comment:
Did you check this works really ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
