jomarko commented on code in PR #2426:
URL:
https://github.com/apache/incubator-kie-tools/pull/2426#discussion_r1636795183
##########
packages/stunner-editors/kie-wb-common-stunner/kie-wb-common-stunner-sets/kie-wb-common-stunner-bpmn/kie-wb-common-stunner-bpmn-client/src/main/java/org/kie/workbench/common/stunner/bpmn/client/forms/fields/variablesEditor/VariablesEditorFieldRenderer.java:
##########
@@ -272,7 +278,7 @@ public boolean isBoundToNodes(String name) {
public void removeVariable(final VariableRow variableRow) {
if (isBoundToNodes(variableRow.getName())) {
- // error popup was here
+ notification.fire(new
NotificationEvent(StunnerFormsClientFieldsConstants.CONSTANTS.DeleteDiagramVariableError(),
NotificationEvent.NotificationType.ERROR));
Review Comment:
If we have a look on `StunnerFormsClientFieldsConstants` we will find there
more constants similar to `DeleteDiagramVariableError` that are currently not
used. It is a sign, they were used in old code ( `kie-wb-common` repository )
and probably we do not display some messages now, that we used to display in
past. Should this PR investigate it more and bring back more similar
notification messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
