Josephblt commented on code in PR #2421:
URL:
https://github.com/apache/incubator-kie-tools/pull/2421#discussion_r1638517567
##########
packages/webpack-base/env/index.js:
##########
@@ -23,19 +23,23 @@ module.exports = composeEnv([], {
vars: varsWithName({
WEBPACK__minimize: {
default: undefined,
- description: "",
+ description:
+ "Whether or not `webpack` should minimize its bundled files. Can be
`true` or `false`. Works for all packages on invokations of `webpack` during a
`kie-tools` build.",
},
WEBPACK__tsLoaderTranspileOnly: {
default: undefined,
- description: "",
+ description:
+ "Whether or not `webpack` should skip type-checking TypeScript files.
Can be `true` or `false`. Works for all packages on invokations of `webpack`
during a `kie-tools` build.",
Review Comment:
Same as above, Invokation typo.
##########
packages/webpack-base/env/index.js:
##########
@@ -23,19 +23,23 @@ module.exports = composeEnv([], {
vars: varsWithName({
WEBPACK__minimize: {
default: undefined,
- description: "",
+ description:
+ "Whether or not `webpack` should minimize its bundled files. Can be
`true` or `false`. Works for all packages on invokations of `webpack` during a
`kie-tools` build.",
},
WEBPACK__tsLoaderTranspileOnly: {
default: undefined,
- description: "",
+ description:
+ "Whether or not `webpack` should skip type-checking TypeScript files.
Can be `true` or `false`. Works for all packages on invokations of `webpack`
during a `kie-tools` build.",
},
WEBPACK__sourceMaps: {
default: undefined,
- description: "",
+ description:
+ "Whether or not `webpack` should include source maps for its bundled
files. Can be `true` or `false`. Works for all packages on invokations of
`webpack` during a `kie-tools` build.",
Review Comment:
Same as above, Invokation typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
