tiagobento commented on code in PR #2406:
URL:
https://github.com/apache/incubator-kie-tools/pull/2406#discussion_r1643561488
##########
.syncpackrc.json:
##########
@@ -1 +1,12 @@
-{}
+{
+ "versionGroups": [
+ {
+ "dependencies": ["prettier"],
+ "packages": [
+ "@kie-tools/uniforms-bootstrap4-codegen",
+ "@kie-tools/uniforms-patternfly-codegen",
+ "@kie-tools/yaml-language-server"
+ ]
+ }
+ ]
+}
Review Comment:
Would be great to make those already be mapped by an issue, so we don't
loose track of this version discrepancy.
##########
packages/sonataflow-operator/package.json:
##########
@@ -22,17 +22,17 @@
"bump-version": "run-script-os",
"bump-version:darwin:linux": "./hack/bump-version.sh",
"bump-version:win32": "echo 'Bumping version not supported on Windows'",
- "format": "prettier --write .",
+ "format": "prettier --write . --ignore-path=../../.prettierignore
--ignore-path=../../.gitignore",
Review Comment:
There are other packages doing the same thing, but you didn't add the
`--ignore-path` argument to them. Why?
##########
.prettierignore:
##########
Review Comment:
Why ignore XSDs?
##########
package.json:
##########
@@ -23,23 +23,18 @@
"@kie-tools-scripts/update-kogito-version": "workspace:*",
"@kie-tools-scripts/update-stream-name": "workspace:*",
"@kie-tools-scripts/update-version": "workspace:*",
- "@nice-move/prettier-plugin-package-json": "^0.6.1",
- "@prettier/plugin-xml": "^2",
+ "@nice-move/prettier-plugin-package-json": "^0.8.0",
+ "@prettier/plugin-xml": "^3.4.1",
Review Comment:
Still no change do XMLs... I wonder if this is working, to be honest. Maybe
we leave that for
- https://github.com/apache/incubator-kie-issues/issues/1156
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
