ljmotta commented on code in PR #2456:
URL:
https://github.com/apache/incubator-kie-tools/pull/2456#discussion_r1664251068
##########
packages/boxed-expression-component/src/expressions/LiteralExpression/LiteralExpression.tsx:
##########
@@ -209,7 +209,7 @@ export function LiteralExpression({
}, []);
return (
- <div className={`literal-expression`}>
+ <div className={`literal-expression`}
data-testid={`literal-expression-${id}`}>
Review Comment:
Please, norrow the `data-testid` scope. On the new DMN Editor we're using
the `kie-tools--dmn-editor--`. I think we could use `kie-tools--bee--`. WDYT?
Either way, this applies to all `data-testid` from the Boxed Expression Editor.
##########
packages/boxed-expression-component/stories/getDefaultBoxedExpressionForStories.ts:
##########
@@ -253,6 +257,66 @@ export function getDefaultBoxedExpressionForStories({
};
widthsById.set(filterExpression["@_id"]!, [FILTER_EXPRESSION_MIN_WIDTH]);
return filterExpression;
+ } else if (logicType === "conditional") {
+ const conditionalExpression: BoxedConditional = {
+ __$$element: "conditional",
+ "@_id": generateUuid(),
+ if: {
+ "@_id": generateUuid(),
+ expression: undefined as any,
Review Comment:
No problem using the `as any`, but on another locations we use the `!`. I
think we must stick with one. Either way, we need to add the comment regarding
the spec discrepancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
