yesamer commented on PR #6014: URL: https://github.com/apache/incubator-kie-drools/pull/6014#issuecomment-2222213004
@jomarko Thank you for your questions. 1. The import's parent is the `Definition` element. If that is missed, the DMN file is invalid, so I guess it's safe to don't perform a null check 2. The equals were already present in the original code IINW, anyway in this case, I guess it's correct using `.equals()`. For Instance, if the namespace is null, I prefer to have a NPE than a false, because namespace = null is an invalid status that should result in an Exception 3. For the LOGGER messages, I tried to use very concise messages. For error messages, I wrote more verbose messages, because they will be consumed by the final user (in the terminal or UI, eg. Business Central). I guess using a return line could be a nice improvement in case of very long messages, yeah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
