tiagobento commented on code in PR #2463:
URL:
https://github.com/apache/incubator-kie-tools/pull/2463#discussion_r1676690495
##########
packages/feel-input-component/showcase/tsconfig.json:
##########
Review Comment:
same
##########
packages/dashbuilder-editor/dev-webapp/tsconfig.json:
##########
Review Comment:
why can't the dev-webapp have its own tsconfig?
##########
packages/pmml-editor/e2e-tests/e2e/data-dictionary.cy.ts:
##########
@@ -17,12 +17,9 @@
* under the License.
*/
-import { env } from "../../env";
-const buildEnv = env;
-
describe("Data Dictionary Test", () => {
beforeEach(() => {
- cy.visit(`http://localhost:${buildEnv.pmmlEditor.dev.port}/`);
+ cy.visit(`http://localhost:9005/`);
Review Comment:
why? i mean, tests are part of the build... i don't see anything wrong with
tests depending on build-env... can you elaborate?
##########
packages/pmml-editor/e2e-tests/fixtures/compound-predicate.pmml:
##########
@@ -1,23 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
- ~ Licensed to the Apache Software Foundation (ASF) under one
- ~ or more contributor license agreements. See the NOTICE file
- ~ distributed with this work for additional information
- ~ regarding copyright ownership. The ASF licenses this file
- ~ to you under the Apache License, Version 2.0 (the
- ~ "License"); you may not use this file except in compliance
- ~ with the License. You may obtain a copy of the License at
- ~
- ~ http://www.apache.org/licenses/LICENSE-2.0
- ~
- ~ Unless required by applicable law or agreed to in writing,
- ~ software distributed under the License is distributed on an
- ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- ~ KIND, either express or implied. See the License for the
- ~ specific language governing permissions and limitations
- ~ under the License.
--->
-PMML xmlns="http://www.dmg.org/PMML-4_4"; version="4.4">
+<PMML xmlns="http://www.dmg.org/PMML-4_4"; version="4.4">
Review Comment:
why remive the xml declaration tag?
##########
packages/online-editor/src/importFromUrl/ImportableUrlHooks.tsx:
##########
@@ -71,7 +71,7 @@ export function isCertainlyGit(urlType: UrlType) {
);
}
-export function isPotentiallyGit(urlType: UrlType) {
+export function isPotentiallyGit(urlType: UrlType): boolean {
Review Comment:
why?
##########
packages/import-java-classes-component/tsconfig.json:
##########
@@ -1,12 +1,7 @@
{
- "extends": "@kie-tools/tsconfig/tsconfig.json",
+ "extends": "@kie-tools/tsconfig/tsconfig.esm.json",
"compilerOptions": {
- "outDir": "dist",
- "resolveJsonModule": true,
- "esModuleInterop": true,
- "target": "es6",
- "moduleResolution": "node",
+ "jsx": "react-jsx",
"types": ["@testing-library/jest-dom"]
Review Comment:
I know this was already there, but think about it... Why should a
`tsconfig.json` that is used to compile a library have the Jest types available
to it? I mean, this should be available only on test files...
##########
packages/pmml-editor/e2e-tests/e2e/predicate.cy.ts:
##########
@@ -230,7 +230,10 @@ describe("Predicate Test", () => {
});
cy.ouiaId("edit-attribute").within(() => {
- cy.ouiaId("predicate").find("div:first").should("have.text",
"1test·>·3").type(" or test<0");
+ // cy.ouiaId("predicate").find("div:first").invoke("text").then((text)
=> {
+ // expect(text.replace(/\u00a0/g, ' ')).equal()
+ // })
Review Comment:
?
##########
packages/chrome-extension-test-helper/src/framework/LocatorWaitAction.ts:
##########
@@ -27,7 +27,7 @@ export default class LocatorWaitAction {
public constructor(
private readonly driver: WebDriver,
private readonly by: By,
- private readonly timeout: number = timeout ??
LocatorWaitAction.DEFAULT_TIMEOUT
+ private readonly timeout: number = LocatorWaitAction.DEFAULT_TIMEOUT
Review Comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
