jstastny-cz commented on code in PR #6026:
URL:
https://github.com/apache/incubator-kie-drools/pull/6026#discussion_r1679476595
##########
.ci/jenkins/Jenkinsfile.deploy:
##########
@@ -134,13 +134,9 @@ pipeline {
}
if (isRelease()) {
-
release.gpgImportKeyFromFileWithPassword(getReleaseGpgSignKeyCredsId(),
getReleaseGpgSignPassphraseCredsId())
- withCredentials([string(credentialsId:
getReleaseGpgSignPassphraseCredsId(), variable: 'SIGNING_KEY_PASSWORD')]) {
-
mavenCommand.withProperty('gpg.passphrase', SIGNING_KEY_PASSWORD)
- .withProfiles(['apache-release'])
- // If there are passwords, this needs to
be duplicated within the withCredentials block.
- mavenRunClosure()
- }
+
release.gpgImportKeyFromStringWithoutPassword(getReleaseGpgSignKeyCredsId())
+ mavenCommand.withProfiles(['apache-release'])
Review Comment:
If the credentials are not passed to maven command now, we could inline the
mavenRunClosure after the if statement end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
