thiagoelg commented on code in PR #2463:
URL:
https://github.com/apache/incubator-kie-tools/pull/2463#discussion_r1683410069
##########
packages/online-editor/src/importFromUrl/ImportableUrlHooks.tsx:
##########
@@ -71,7 +71,7 @@ export function isCertainlyGit(urlType: UrlType) {
);
}
-export function isPotentiallyGit(urlType: UrlType) {
+export function isPotentiallyGit(urlType: UrlType): boolean {
Review Comment:
But the method still returns `true` or `false` right? Does that inference
causes Typescript errors somewhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]