domhanak commented on code in PR #2478:
URL:
https://github.com/apache/incubator-kie-tools/pull/2478#discussion_r1687601624
##########
packages/runtime-tools-swf-enveloped-components/src/workflowDefinitions/envelope/components/WorkflowDefinitionList/WorkflowDefinitionList.tsx:
##########
@@ -44,6 +44,31 @@ const WorkflowDefinitionList:
React.FC<WorkflowDefinitionListProps & OUIAProps>
const [isLoading, setIsLoading] = useState<boolean>(true);
const [filterWorkflowNames, setFilterWorkflowNames] = useState<string[]>([]);
const [error, setError] = useState<string>();
+ const [defaultPageSize] = useState<number>(10);
+ const [isLoadingMore, setIsLoadingMore] = useState<boolean>(false);
+ // const [selectableInstances, setSelectableInstances] = useState<number>(0);
+ const [limit, setLimit] = useState<number>(defaultPageSize);
+
+ const doQuery = async (
+ _offset: number,
+ _limit: number,
+ _resetWorkflows: boolean,
+ _resetPagination: boolean = false,
+ _loadMore: boolean = false
+ ): Promise<void> => {
+ setIsLoadingMore(_loadMore);
+ // setSelectableInstances(0);
Review Comment:
commented code
##########
packages/sonataflow-operator/config/manager/kustomization.yaml:
##########
@@ -41,7 +41,7 @@ kind: Kustomization
images:
- name: controller
newName: docker.io/apache/incubator-kie-sonataflow-operator
- newTag: main
+ newTag: 0.0.0
Review Comment:
Not sure if this shouldn't be left as `main`. See -
https://hub.docker.com/r/apache/incubator-kie-sonataflow-operator/tags
##########
packages/runtime-tools-swf-enveloped-components/src/workflowDefinitions/envelope/components/WorkflowDefinitionList/WorkflowDefinitionList.tsx:
##########
@@ -44,6 +44,31 @@ const WorkflowDefinitionList:
React.FC<WorkflowDefinitionListProps & OUIAProps>
const [isLoading, setIsLoading] = useState<boolean>(true);
const [filterWorkflowNames, setFilterWorkflowNames] = useState<string[]>([]);
const [error, setError] = useState<string>();
+ const [defaultPageSize] = useState<number>(10);
+ const [isLoadingMore, setIsLoadingMore] = useState<boolean>(false);
+ // const [selectableInstances, setSelectableInstances] = useState<number>(0);
Review Comment:
commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
