ljmotta commented on code in PR #2441:
URL:
https://github.com/apache/incubator-kie-tools/pull/2441#discussion_r1688455591
##########
packages/scesim-editor/tests-e2e/__screenshots__/chromium/useCases/are-they-old-enough-test.png:
##########
Review Comment:
This is the only screenshot if the right padding.
##########
packages/scesim-editor/tests-e2e/__screenshots__/chromium/useCases/traffic-violation-test.png:
##########
Review Comment:
Not sure if this right padding is related to the Playwright or the locator
choice.
##########
packages/scesim-editor/tests-e2e/features/keyboard/keyboard.spec.ts:
##########
@@ -35,19 +35,19 @@ test.describe("Keyboard", () => {
await table.selectCell({ rowNumber: "1", columnNumber: 0 });
await table.navigateRight({ rowNumber: "1", columnNumber: 0, type:
Type.KEYBOARD_SHORTCUT });
- await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-screenshot-right.png");
+ await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-right.png");
await table.navigateDown({ rowNumber: "1", columnNumber: 1, type:
Type.KEYBOARD_SHORTCUT });
- await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-screenshot-down.png");
+ await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-down.png");
await table.navigateLeft({ rowNumber: "2", columnNumber: 1, type:
Type.KEYBOARD_SHORTCUT });
- await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-screenshot-left.png");
+ await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-left.png");
await table.navigateUp({ rowNumber: "2", columnNumber: 0, type:
Type.KEYBOARD_SHORTCUT });
- await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-screenshot-up.png");
+ await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-up.png");
await table.deselectCell({ rowNumber: "2", columnNumber: 0 });
- await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-escaped-screenshot.png");
+ await
expect(testScenarioTable.get()).toHaveScreenshot("navigation-escaped.png");
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
