ljmotta commented on code in PR #2458:
URL:
https://github.com/apache/incubator-kie-tools/pull/2458#discussion_r1688492331
##########
packages/boxed-expression-component/tests-e2e/features/resizing/resizing.spec.ts:
##########
@@ -238,6 +239,24 @@ test.describe("Resizing", () => {
expect(await nestedEntry.boundingBox()).toHaveProperty("width", 120);
expect(await
nestedLiteralExpresison.boundingBox()).toHaveProperty("width", 212);
});
+
+ test("should assign width values to all columns when no width defined",
async ({
+ stories,
+ page,
+ resizing,
+ jsonModel,
+ }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description:
"https://github.com/apache/incubator-kie-issues/issues/1374";,
+ });
+
+ await stories.openBoxedContext("installment-calculation");
+ const firstEntry = page.getByRole("cell", { name: "Fee (number)" });
+ await resizing.resizeCell(firstEntry, { x: 0, y: 0 }, { x: 50, y: 0 });
Review Comment:
I could see that you've created a variable as I've created on the first
tests I've made using the `resize.resizeCell` fixture. Currently, we're tring
to not add any variable on the tests. I guess it will change a little with the
revamp on the Boxed Expression tests that Daniel is working on
https://github.com/apache/incubator-kie-tools/pull/2456, but for this case, I
can't see the necessity of a variable here, could you please inline it? The
same applies for the other tests.
##########
packages/online-editor/static/samples/Sample.dmn:
##########
Review Comment:
Why we need to change the sample file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
