martinweiler commented on code in PR #3551:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3551#discussion_r1691847438
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/FlowTest.java:
##########
@@ -1325,16 +1368,13 @@ public void
testMultipleInOutgoingSequenceFlowsDisable() throws Exception {
@Test
public void testConditionalFlow() throws Exception {
- System.setProperty("jbpm.enable.multi.con", "true");
- String processId = "designer.conditional-flow";
+ Application app = ProcessTestHelper.newApplication();
- kruntime =
createKogitoProcessRuntime("BPMN2-ConditionalFlowWithoutGateway.bpmn2");
+ org.kie.kogito.process.Process<ConditionalFlowWithoutGatewayModel>
definition = ConditionalFlowWithoutGatewayProcess.newProcess(app);
+
org.kie.kogito.process.ProcessInstance<ConditionalFlowWithoutGatewayModel>
instance = definition.createInstance(definition.createModel());
+ instance.start();
- KogitoProcessInstance wpi = kruntime.startProcess(processId);
-
- assertProcessInstanceFinished(wpi, kruntime);
- assertNodeTriggered(wpi.getStringId(), "start", "script", "end1");
- System.clearProperty("jbpm.enable.multi.con");
+
assertThat(instance.status()).isEqualTo(org.kie.kogito.process.ProcessInstance.STATE_COMPLETED);
Review Comment:
It would be good to assert the type of end node here as in the previous
version of the code, to also check the correct evaluation of the conditional
gateway, and not just the functioning of the `jbpm.enable.multi.con` flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
