gitgabrio commented on PR #3579: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3579#issuecomment-2252204011
> > @fjtirado please read [here](https://github.com/apache/incubator-kie-kogito-runtimes/blob/8613c8e30e76e369f045bb43ffdb6d69cc636da3/springboot/integration-tests/pom.xml#L57) : it seems your first approach was actually the right one 👍 😄 > > @gitgabrio I do not know how to say that openapi-common is not direct or transitive or a dependency at all for SpringBoot (as the quarkus one) and is still being considered by the compare goal. That means that when we change any quarkus dependency, we will have to add it to the springboot pom in order to get green light. Do you really think thats the right approach? The right approach would be to go inside each of such it tests, remove the boms, and add only the actually required dependency. Then, eventually, the parent pom would need to declare only the actually needed dependecies. But since we need a fix now, and, as you may read by yourself in the comment of the very pom you modified, this is already the current approach, I would say that for the moment being is the best thing to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
