tiagobento commented on code in PR #2485:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2485#discussion_r1693456886


##########
packages/dmn-editor/tests-e2e/__fixtures__/propertiesPanel/parts/dataTypeProperties.ts:
##########
@@ -28,6 +28,56 @@ export class DataTypeProperties {
 
   public async setDataType(args: { newDataType: DataType }) {
     await this.panel.getByPlaceholder("Select a data type...").click();
+    await this.panel.getByPlaceholder("Select a data 
type...").press("ControlOrMeta+a");
+    await this.panel.getByPlaceholder("Select a data 
type...").fill(args.newDataType);
     await this.page.getByRole("option").getByText(args.newDataType, { exact: 
true }).click();
   }
+
+  public async setCustomDataType(args: { newDataType: string }) {
+    await this.panel.getByPlaceholder("Select a data type...").click();
+    await this.panel.getByPlaceholder("Select a data 
type...").press("ControlOrMeta+a");
+    await this.panel.getByPlaceholder("Select a data 
type...").fill(args.newDataType);
+    await this.page.getByRole("option").getByText(`${args.newDataType} `, { 
exact: false }).click();
+  }
+
+  public getDataType() {
+    return this.panel.getByPlaceholder("Select a data type...");
+  }
+
+  public getConstraintSection() {
+    return this.panel.getByText("Constraint");
+  }
+
+  public getConstraintButton(args: { type: ConstraintType }) {
+    switch (args.type) {
+      case ConstraintType.ENUMERATION:
+        return this.panel.getByRole("button", { name: 
ConstraintType.ENUMERATION, exact: true });
+      case ConstraintType.EXPRESSION:
+        return this.panel.getByRole("button", { name: 
ConstraintType.EXPRESSION, exact: true });
+      case ConstraintType.NONE:
+        return this.panel.getByRole("button", { name: ConstraintType.NONE, 
exact: true });
+      case ConstraintType.RANGE:
+        return this.panel.getByRole("button", { name: ConstraintType.RANGE, 
exact: true });

Review Comment:
   Great catch @kbowers-ibm. Well spotted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to