fjtirado commented on code in PR #2492:
URL:
https://github.com/apache/incubator-kie-tools/pull/2492#discussion_r1694883961
##########
packages/sonataflow-quarkus-devui/sonataflow-quarkus-devui/src/main/java/org/kie/sonataflow/swf/tools/runtime/rpc/SonataFlowQuarkusExtensionJsonRPCService.java:
##########
@@ -43,19 +43,26 @@ public class SonataFlowQuarkusExtensionJsonRPCService {
public static final String ALL_WORKFLOWS_IDS_QUERY = "{ \"operationName\":
\"getAllProcessesIds\", \"query\": \"query getAllProcessesIds{
ProcessInstances{ id } }\" }";
+ public static final String IS_LOCAL_CLUSTER =
"sonataflow.devui.isLocalCluster";
+
private WebClient dataIndexWebClient;
private final Vertx vertx;
+ private boolean isLocalCluster;
Review Comment:
If we are reading the property just once, why not using injection to read
the value
https://quarkus.io/guides/config#inject-the-configuration
##########
packages/sonataflow-quarkus-devui/sonataflow-quarkus-devui/src/main/java/org/kie/sonataflow/swf/tools/runtime/rpc/SonataFlowQuarkusExtensionJsonRPCService.java:
##########
@@ -43,19 +43,26 @@ public class SonataFlowQuarkusExtensionJsonRPCService {
public static final String ALL_WORKFLOWS_IDS_QUERY = "{ \"operationName\":
\"getAllProcessesIds\", \"query\": \"query getAllProcessesIds{
ProcessInstances{ id } }\" }";
+ public static final String IS_LOCAL_CLUSTER =
"sonataflow.devui.isLocalCluster";
+
private WebClient dataIndexWebClient;
private final Vertx vertx;
+ private boolean isLocalCluster;
Review Comment:
If we are reading the property just once, why not using injection to read
the value?
https://quarkus.io/guides/config#inject-the-configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
