rhkp commented on code in PR #1791: URL: https://github.com/apache/incubator-kie-kogito-images/pull/1791#discussion_r1697010339
########## modules/kogito-postgres-db-migration-deps/artifacts/db-migration-files/data-index/V1.32.0__data_index_create.sql: ########## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +SET SEARCH_PATH="$DATA_INDEX_SCHEMA"; Review Comment: @wmedvede If we only use the default schemas for the DB's (which is the case currently?), we can easily remove schemas from our implementation. However, the moment end-users want to use different schemas - same DB for DI/JS but different schemas for DI/JS - Or different DBs for DI/JS but specific schemas for DI/JS we will need to set the Search Path for postgres. Please let me know if we want to support specific schemas(in this case we cannot remove search path for schema) or just use default schemas(in this case we can remove search path)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
