fjtirado commented on code in PR #2498:
URL:
https://github.com/apache/incubator-kie-tools/pull/2498#discussion_r1697433088
##########
packages/sonataflow-quarkus-devui/sonataflow-quarkus-devui/src/main/java/org/kie/sonataflow/swf/tools/runtime/rpc/SonataFlowQuarkusExtensionJsonRPCService.java:
##########
@@ -58,7 +58,8 @@ public SonataFlowQuarkusExtensionJsonRPCService(Vertx vertx) {
@PostConstruct
public void init() {
- isLocalCluster =
ConfigProvider.getConfig().getOptionalValue(IS_LOCAL_CLUSTER,
Boolean.class).orElse(false);
+ //temporary, set isLocalCluster always true since sonataflow-dev-ui
works in k8s cluster.
+ isLocalCluster =
ConfigProvider.getConfig().getOptionalValue(IS_LOCAL_CLUSTER,
Boolean.class).orElse(true);
Review Comment:
As commented in a previous PR, I think this should have been done through
injection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
