fjtirado commented on PR #3594:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3594#issuecomment-2262694930

   @gitgabrio 
   Yes, Im referring to kogito-serverless-workflow-openapi-common. Once this 
file has been uploaded to the maven repo, the build works, so it can be removed 
from the springboot it. 
   As I tried to explain in the previous PR, reproducible build compare goal is 
trying to compare all artifacts, not just sprinboot it dependencies. Springboot 
IT dependnecies (build in that load) are available for the comparison, so 
compare does no try to download them. But not springboot IT dependencies (for 
example, kogito-serverless-workflow-openapi-common) will have to be retrieved 
from maven central (because they are not installed in the local repo used by 
the sprinboot it, once you make it a dependency, it is installe and pr passed)
   I agree we have a huge problem with this and thats why I proposed to disable 
compare goal for springboot it, since any change in a non sprinboot it 
dependency jar will provoke a red flag in the PR. 
   Now that the jar is now in central, we can removed the dependency, which 
makes no sense for SpringBoot IT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to