gitgabrio commented on code in PR #6040:
URL:
https://github.com/apache/incubator-kie-drools/pull/6040#discussion_r1700261414
##########
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/FEEL12ExtendedForLoopTest.java:
##########
@@ -45,10 +45,15 @@ protected void instanceTest(String expression, Object
result, FEELEvent.Severity
}
private static Collection<Object[]> data() {
+ List<Integer> nullObject = new ArrayList<>();
Review Comment:
@bncriju
Sorry for late review, but could you pls remove this
`List<Integer> nullObject = new ArrayList<>();`
and follow the same approach we did elsewhere (i.e.
`Stream.of(null, null, null)` inside the test itself)
Beside: `nullObject` is an extemely misleading term, because
1. this is not a generic object, but a List
2. this is not a `null` `Object`, but a `List` filled with `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
