martinweiler commented on code in PR #3601:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3601#discussion_r1700848933
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/StandaloneBPMNProcessTest.java:
##########
@@ -720,11 +804,15 @@ public void afterProcessStarted(ProcessStartedEvent
event) {
}
@Test
- public void testSignalEnd() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/event/BPMN2-SignalEndEvent.bpmn2");
- Map<String, Object> params = new HashMap<>();
- params.put("x", "MyValue");
- kruntime.startProcess("SignalEndEvent", params);
+ public void testSignalEnd() {
+ Application app = ProcessTestHelper.newApplication();
+
+ org.kie.kogito.process.Process<SignalEndEventModel> processDefinition
= SignalEndEventProcess.newProcess(app);
+ SignalEndEventModel model = processDefinition.createModel();
+ model.setX("MyValue");
+
+ org.kie.kogito.process.ProcessInstance<SignalEndEventModel> instance =
processDefinition.createInstance(model);
+ instance.start();
Review Comment:
This test lacks an assert on whether the end signal has actually been sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
