jomarko commented on code in PR #2508:
URL:
https://github.com/apache/incubator-kie-tools/pull/2508#discussion_r1704975647
##########
packages/dmn-editor/src/diagram/Palette.tsx:
##########
@@ -245,7 +245,11 @@ export function Palette({ pulse }: { pulse: boolean }) {
<br />
<aside className={"kie-dmn-editor--external-nodes-panel-toggle"}>
{diagram.openLhsPanel === DiagramLhsPanel.EXTERNAL_NODES && (
- <div className={"kie-dmn-editor--palette-nodes-popover"} style={{
maxHeight }}>
+ <div
+ className={"kie-dmn-editor--palette-nodes-popover"}
+ style={{ maxHeight }}
+ data-testid={"kie-tools--dmn-editor--external-nodes-container"}
+ >
Review Comment:
@tiagobento actually we are about to add `data-testid` also for the `DRG
Nodes` panel, see the PR https://github.com/apache/incubator-kie-tools/pull/2462
One thing we could unify is the `data-testid` suffix. @danielzhe is using
`-container` while me is using `-popover`, what do you prefer? I chose
`-popover` due to related `className`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
